Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][FIX] shopinvader: Shopinvader Manager inherits from queue manager #560

Merged
merged 1 commit into from
Mar 23, 2020
Merged

[10.0][FIX] shopinvader: Shopinvader Manager inherits from queue manager #560

merged 1 commit into from
Mar 23, 2020

Conversation

rousseldenis
Copy link
Contributor

The implied group was inversed.

Shopinvader manager must inherits from queue job manager, not the inverse.

@rousseldenis rousseldenis added this to the 10.0 milestone Jan 21, 2020
@rousseldenis
Copy link
Contributor Author

@simahawk @Cedric-Pigeon

@codecov-io
Copy link

codecov-io commented Jan 21, 2020 •
edited
Loading

Codecov Report

Merging #560 into 10.0 will decrease coverage by 29.56%.
The diff coverage is 59.74%.

Impacted file tree graph

@@             Coverage Diff             @@
##             10.0     #560       +/-   ##
===========================================
- Coverage   89.74%   60.17%   -29.57%     
===========================================
  Files         143       54       -89     
  Lines        3773     2172     -1601     
===========================================
- Hits         3386     1307     -2079     
- Misses        387      865      +478
Impacted Files Coverage Δ
shopinvader/models/shopinvader_partner.py 25.37% <ø> (-74.63%) ⬇️
shopinvader/shopinvader_response.py 100.00% <ø> (+6.66%) ⬆️
..._template_multi_link/models/shopinvader_product.py 31.81% <ø> (-68.19%) ⬇️
shopinvader/services/address.py 40.00% <20.00%> (-53.45%) ⬇️
shopinvader/services/sale.py 44.68% <28.57%> (-52.94%) ⬇️
shopinvader/services/abstract_download.py 37.83% <37.83%> (ø)
shopinvader/models/sale.py 78.21% <50.00%> (-17.08%) ⬇️
shopinvader/services/invoice.py 42.85% <50.00%> (-38.97%) ⬇️
shopinvader/services/cart.py 54.20% <70.17%> (-34.94%) ⬇️
shopinvader/controllers/main.py 40.00% <75.00%> (+1.53%) ⬆️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93819ce...4666851. Read the comment docs.

@Cedric-Pigeon
Copy link

Cedric-Pigeon commented Mar 19, 2020 •
edited
Loading

@simahawk Could you please have a look at this simple one?

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sebastienbeau
sebastienbeau approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@lmignon lmignon mentioned this pull request Mar 19, 2020
Closed
77 tasks
@rousseldenis
Copy link
Contributor Author

/ocabot merge minor

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 10.0-ocabot-merge-pr-560-by-rousseldenis-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Mar 20, 2020
Merge PR #560 into 10.0
7d358b0 
Signed-off-by rousseldenis
@shopinvader-git-bot
Copy link

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-560-by-rousseldenis-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@Cedric-Pigeon
Copy link

/ocabot merge minor

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 10.0-ocabot-merge-pr-560-by-Cedric-Pigeon-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Mar 20, 2020
Merge PR #560 into 10.0
1db9e0b 
Signed-off-by Cedric-Pigeon
@shopinvader-git-bot
Copy link

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-560-by-Cedric-Pigeon-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Mar 20, 2020
Merge PR #560 into 10.0
f90d379 
Signed-off-by Cedric-Pigeon
@shopinvader-git-bot
Copy link

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-560-by-Cedric-Pigeon-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Mar 20, 2020
Merge PR #560 into 10.0
3480ca5 
Signed-off-by Cedric-Pigeon
@shopinvader-git-bot
Copy link

@Cedric-Pigeon your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-560-by-Cedric-Pigeon-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@Cedric-Pigeon Cedric-Pigeon force-pushed the 10.0-fix-shopinvader_queue_manager-dro branch from 01a0b21 to 4666851 Compare March 23, 2020 06:59
@Cedric-Pigeon
Copy link

/ocabot merge minor

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 10.0-ocabot-merge-pr-560-by-Cedric-Pigeon-bump-minor, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 5b7c0be into shopinvader:10.0 Mar 23, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 8d1bb18. Thanks a lot for contributing to shopinvader. ❤️

@rousseldenis rousseldenis deleted the 10.0-fix-shopinvader_queue_manager-dro branch March 23, 2020 12:32
@HviorForgeFlow HviorForgeFlow mentioned this pull request May 26, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@sebastienbeau sebastienbeau sebastienbeau approved these changes

@Cedric-Pigeon Cedric-Pigeon Cedric-Pigeon approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 ready to merge
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rousseldenis @codecov-io @Cedric-Pigeon @shopinvader-git-bot @simahawk @sebastienbeau